Counterexamples: show strings, not address-of-character #4241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
martin-cs,
peterschrammel,
pkesseli and
smowton
as code owners
smowton
approved these changes
Feb 21, 2019
| @@ -104,6 +104,23 @@ exprt pointer_logict::pointer_expr( | |||
| // https://gcc.gnu.org/onlinedocs/gcc-4.8.0/gcc/Pointer-Arith.html | |||
| if(subtype.id() == ID_empty) | |||
| subtype = char_type(); | |||
| if( | |||
| object_expr.id() == ID_string_constant && | |||
| object_expr.type().id() == ID_array) | |||
There was a problem hiding this comment.
I suspect if it's a string_constant then the array is an invariant?
There was a problem hiding this comment.
Indeed, leaving that check now to an unconditional to_array_type.
tautschnig
force-pushed
the
cex-string
branch
from
d62667c to
db0e770
Compare
Pointers to strings (or into strings) should not be printed as address-of-character. This was an undesired side-effect of d4296f1 ("Use get_subexpression_at_offset in pointer_logict").
tautschnig
force-pushed
the
cex-string
branch
from
db0e770 to
6d31679
Compare
kroening
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointers to strings (or into strings) should not be printed as
address-of-character. This was an undesired side-effect of d4296f1 ("Use
get_subexpression_at_offset in pointer_logict").